Skip to content

fix(ui): improve form control accessibility#22

Merged
wyf027 merged 3 commits into
mainfrom
codex/daily-component-a11y-2026-07-01
Jul 5, 2026
Merged

fix(ui): improve form control accessibility#22
wyf027 merged 3 commits into
mainfrom
codex/daily-component-a11y-2026-07-01

Conversation

@wyf027

@wyf027 wyf027 commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add combobox/listbox ARIA semantics and keyboard selection to AutoComplete.
  • Add spinbutton semantics, named controls, and keyboard stepping to InputNumber.
  • Cover both components with focused Vitest + Testing Library tests.

Verification

  • npx prettier --write packages/ui/src/components/form/controls/AutoComplete/AutoComplete.tsx packages/ui/src/components/form/controls/AutoComplete/AutoComplete.test.tsx packages/ui/src/components/form/controls/InputNumber/InputNumber.tsx packages/ui/src/components/form/controls/InputNumber/InputNumber.test.tsx
  • npx vitest run src/components/form/controls/AutoComplete/AutoComplete.test.tsx src/components/form/controls/InputNumber/InputNumber.test.tsx
  • npx eslint src/components/form/controls/AutoComplete/AutoComplete.tsx src/components/form/controls/AutoComplete/AutoComplete.test.tsx src/components/form/controls/InputNumber/InputNumber.tsx src/components/form/controls/InputNumber/InputNumber.test.tsx
  • npm run lint:ui
  • npm run typecheck:ui
  • npm run test:ui
  • npm run build

@ecc-tools

ecc-tools Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2214c92c26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ecc-tools

ecc-tools Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@ecc-tools

ecc-tools Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@wyf027 wyf027 merged commit 3f2e467 into main Jul 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant